変数の書き方を修正

diff --git a/global_ip_chk.sh b/global_ip_chk.sh
index c312b0346681ec814a35f403a3692507869580b4..7c3fe25e6140c7eafb91f73cef981821892126ee 100755 (executable)
--- a/global_ip_chk.sh
+++ b/global_ip_chk.sh
@@ -2,24 +2,26 @@
 BINDIR=~/bin
 IPDIR=~
 
-IPFILE=$IPDIR/globalip.txt
+IPFILE=${IPDIR}/globalip.txt
 
 ECHO=/bin/echo
 LOGGER=/usr/bin/logger
 CAT=/bin/cat
+TEST=/usr/bin/test
+WGET=/usr/bin/wget
 
-NOWIP=$(wget -q -O - ipcheck.ieserver.net)
-if test -s $IPFILE; then
-    CACHEIP=$($CAT $IPFILE)
+IPCHECKSERVER=ipcheck.ieserver.net
+
+NOWIP=$(${WGET} -q -O - ${IPCHECKSERVER})
+if ${TEST} -s ${IPFILE}; then
+    CACHEIP=$(${CAT} ${IPFILE})
 else
     CACHEIP=0.0.0.0
 fi
-if test $NOWIP != $CACHEIP; then
-    $ECHO "Global IP address changed to $NOWIP." | $LOGGER -p local2.info
-    $ECHO $NOWIP >$IPFILE
-    $BINDIR/mydns_ip_update
 if ${TEST} "${NOWIP}" != "${CACHEIP}"; then
+    ${ECHO} "Global IP address changed from ${CACHEIP} to ${NOWIP}." | ${LOGGER} -p local2.info
+    ${ECHO} ${NOWIP} >${IPFILE}
+    ${BINDIR}/mydns_ip_update
 else
-    $ECHO "Global IP address NOT changed. ($NOWIP)" | $LOGGER -p local2.debug
     ${ECHO} "Global IP address does NOT change from ${NOWIP}." | ${LOGGER} -p local2.debug
 fi